Parallelize account and publisher sync #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmzlt
reviewed
Aug 14, 2024
program_admin/__init__.py
Outdated
|
|
||
| if product_updates: | ||
| await self.refresh_program_accounts() | ||
|
|
||
| # Sync publishers | ||
|
|
||
| transactions = [] |
There was a problem hiding this comment.
I think you can define price_feed_transactions and publisher_transactions as two separate lists instead of reusing the same object for the sake of safety.
thmzlt
approved these changes
Aug 14, 2024
ayazabbas
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my tests with 2 validator and 2 publisher nodes, this reduced the program-admin execution time when bringing up Blockmark from 1400 sec to 140 sec. I'll leave it running for a while before merging, just to check that there are no untoward effects.