Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotate pyro.util.py #3393

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Type annotate pyro.util.py #3393

merged 2 commits into from
Sep 16, 2024

Conversation

ordabayevy
Copy link
Member

No description provided.

@@ -3,6 +3,7 @@
# SPDX-License-Identifier: Apache-2.0

[tool.ruff]
extend-exclude = ["*.ipynb"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jupyter Notebooks are linted by default starting from ruff version 0.6.0.
https://docs.astral.sh/ruff/configuration/#jupyter-notebook-discovery

@ordabayevy ordabayevy requested a review from fritzo August 27, 2024 17:55
@ordabayevy ordabayevy changed the title Type annotate pyro/util.py Type annotate pyro.util.py Aug 27, 2024
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. First time I know about overload :)

@fehiepsi fehiepsi merged commit eadf00a into dev Sep 16, 2024
9 checks passed
@ordabayevy ordabayevy deleted the type-util branch September 16, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants