[Bug]: pyRevit CLI Doesn't look for 100% match in extension names when parsing #2367
Comments
TPJW
added
the
Bug
jmcouffin
added
the
Command Line Utility (CLI)
|
This is by design, since the pyRevit/dev/pyRevitLabs/pyRevitLabs.PyRevit/PyRevitExtensions.cs Lines 29 to 33 in f9fa0d2 To perform an exact search, you should use |
|
Huh, well that answers that. Would it be fair to say then that the regex search is why |
To my knowledge, this is the main entrypoint for extensions to be discovered (and IIRC for the extensions window to be properly populated), so yes, we still need it. |
have you tried to do the exact match search as stated in my first answer, using the |
|
FYI, this is the regular expression explained, in which you can see the exact match working https://regex101.com/r/MW4qfM/1 |
Yep, just ran it and it found it fine >>>PS C:\Users\TPJW> pyrevit extensions info TPpyRevitTools
>>>PS C:\Users\TPJW> pyrevit extensions info ^TPpyRevitTools$
Name: "TPpyRevitTools" | Type: "UIExtension" | Repo: "https://github.com/xxx"The reason I had brought that up was me wondering if it may be causing adverse effects for other functions/implementations where I can't pass it the name with regex, like in the extensions window, but at a glance it seems to get the details just fine. If something comes up I'll reopen the issue, but consider it all good for now. Thanks! |
✈ Pre-Flight checks
🐞 Describe the bug
When I go to perform extenion-centreic commands in the pyRevit CLI, I notice (when using the
--debugsuffix) that the CLI is not looking for a 100% match in name when parsing though extensions.I have create a suite of extensions for the firm I work for, with one general extension for all Revit users, and two other, discipline specific, ones. They are named:
I've noticed when using the CLI, for example the command
pyrevit extensions info TPpyRevitTools --debug, that the CLI does not look for a 100% match in the name in the extension, resulting the first extension (TPpyRevitTools) matching with all three.This appears to be causing issues elsewhere, like calling
pyrevit extensionswill pull the right extension type for the disciple specific extensions, but not the general one (sample output below)⌨ Error/Debug Message
Below is the output when running the above-mentioned command in the CLI, where the fault is shown at the end when it matches TPpyRevitTools with the two other discipline-specific extensions as well
And below is the output when calling pyrevit extensions, alongside the extensions.json file
and here's the associated extensions.json
{ "extensions": [ { "builtin": "False", "type": "extension", "rocket_mode_compatible": "False", "name": "TPpyRevitTools", "description": "General pyRevit Tools", "author": "TPJW", "author_profile": "", "url": "", "website": "", "image": "", "dependencies": [] }, { "builtin": "False", "type": "extension", "rocket_mode_compatible": "False", "name": "TPpyRevitToolsARCH", "description": "Architectural pyRevit Tools", "author": "TPJW", "author_profile": "", "url": "", "website": "", "image": "", "dependencies": [] }, { "builtin": "False", "type": "extension", "rocket_mode_compatible": "False", "name": "TPpyRevitToolsELEC", "description": "Electrical pyRevit Tools", "author": "TPJW", "author_profile": "", "url": "", "website": "", "image": "", "dependencies": [] } ] }♻️ To Reproduce
⏲️ Expected behavior
When parsing though extensions, pyRevit CLI should only register a 100% match and not register if the target name is contained in the name being checked.
🖥️ Hardware and Software Setup (please complete the following information)
Additional context
Side note/Question: should we still be needing the extensions.json file? I though the bundle.yaml in each of the extensions root was supposed to take care of holding information for each extension to be displayed when running
pyrevit extensionsas well as in the extension page on the pyRevit toolbar.The text was updated successfully, but these errors were encountered: