From f82d07533f9500ec689673857688a7771b37adf0 Mon Sep 17 00:00:00 2001 From: thumDer <54556708+thumDer@users.noreply.github.com> Date: Fri, 14 Jul 2023 18:55:37 +0200 Subject: [PATCH] hotfix for geometry query if element has no geometry --- pyrevitlib/pyrevit/revit/db/query.py | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/pyrevitlib/pyrevit/revit/db/query.py b/pyrevitlib/pyrevit/revit/db/query.py index 77adc469a..aebd16b2d 100644 --- a/pyrevitlib/pyrevit/revit/db/query.py +++ b/pyrevitlib/pyrevit/revit/db/query.py @@ -1576,10 +1576,14 @@ def get_geometry(element, include_invisible=False, compute_references=False): geom_opts.IncludeNonVisibleObjects = include_invisible geom_opts.ComputeReferences = compute_references geom_objs = [] - for gobj in element.Geometry[geom_opts]: - if isinstance(gobj, DB.GeometryInstance): - inst_geom = gobj.GetInstanceGeometry() - geom_objs.extend(list(inst_geom)) - else: - geom_objs.append(gobj) - return geom_objs + try: + for gobj in element.Geometry[geom_opts]: + if isinstance(gobj, DB.GeometryInstance): + inst_geom = gobj.GetInstanceGeometry() + geom_objs.extend(list(inst_geom)) + else: + geom_objs.append(gobj) + return geom_objs + except TypeError: + mlogger.debug("element %s has no geometry", element.Id.IntegerValue) + return