Allow user to skip validation of pyproject.toml via env var
#4611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
commented
Aug 28, 2024
| the file is valid. Otherwise unexpected behaviours may occur. | ||
| """, | ||
| ) | ||
| return True |
There was a problem hiding this comment.
The warning and env var name are directed towards users unexperienced with setuptools.
Experienced users will be fine.
But I am also happy to change the variable name and warning text.
|
I'm not going to complain if it's merged as-is, but TBH I don't think the warning is really helpful. Users who disable the validation will already know what this implies through the sake of finding the variable in the first place — so I think it's sufficient to document it properly. |
abravalheri
force-pushed
the
issue-4459
branch
2 times, most recently
from
24c0a77
to
593358a
Compare
abravalheri
force-pushed
the
issue-4459
branch
from
593358a
to
b7f7768
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #4459 using the approach mentioned in #4459 (comment).
Pull Request Checklist
newsfragments/.(See documentation for details)