Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tags: accept mac tags without minor versions #579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tags: accept mac tags without minor versions #579

wants to merge 1 commit into from

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Jul 20, 2022

Fixes #578

@FFY00
Copy link
Member Author

FFY00 commented Jul 20, 2022

This is just an initial proposal for the fix. @lawrence-danna-apple can you clarify on the Apple policy? Is the version only omitted starting from 12 and onwards? Is it always omitted, or should we keep the _0 variant? Any other things to keep in mind? Thanks!

@FFY00 FFY00 force-pushed the allow-mac-version-only-major branch 2 times, most recently from d125185 to 0a9ef80 Compare July 21, 2022 20:54
@FFY00 FFY00 marked this pull request as ready for review July 21, 2022 20:54
@FFY00 FFY00 force-pushed the allow-mac-version-only-major branch 3 times, most recently from e1ee4b8 to 0d4dcaf Compare July 21, 2022 21:15
@FFY00 FFY00 force-pushed the allow-mac-version-only-major branch from 0d4dcaf to 8405a84 Compare July 21, 2022 23:10
rgommers
rgommers reviewed Jul 22, 2022
View reviewed changes
packaging/tags.py
)
# Mac OS 11 and 12 seem to omit the minor version, we will keep
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is going to be confusing, see #578 (comment)

@brettcannon
Copy link
Member

@FFY00 Did you want to update this based on the discussion in #578 where we agreed to add the minor-less macOS tags?

brettcannon
brettcannon requested changes Nov 25, 2022
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor-free tags should come after all minor-including tags, not replace them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers left review comments

@brettcannon brettcannon brettcannon requested changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
packaging.tags
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing valid mac tags
5 participants
@FFY00 @brettcannon @rgommers @uranusjr @pradyunsg