Added packaging.utils.create_wheel_filename and create_sdist_filename functions #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
pradyunsg
reviewed
Sep 29, 2022
Comment on lines
+105
to
+106
| ), | ||
| ], |
There was a problem hiding this comment.
Could you add a test putting numpy-1.23.3-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl through parse_..., and putting the result through create_...?
| @@ -119,6 +144,10 @@ def parse_wheel_filename( | |||
| return (name, version, build, tags) | |||
|
|
|||
|
|
|||
| def create_sdist_filename(name: str, version: Version) -> str: | |||
There was a problem hiding this comment.
The parse -> create feels... asymmetric. My instinctive answer for an alternative to create is compose and a Google search got me to https://stackoverflow.com/questions/148857/what-is-the-opposite-of-parse as the first result, which makes me feel validated. :)
Let's change to this naming scheme:
Suggested change
| def create_sdist_filename(name: str, version: Version) -> str: | |
| def compose_sdist_filename(name: str, version: Version) -> str: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #408