Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct the names if a higher MACOS dep target set #819

Closed
wants to merge 2 commits into from
Closed

fix: correct the names if a higher MACOS dep target set #819

wants to merge 2 commits into from

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Sep 8, 2021

Should address #818

mayeut
mayeut reviewed Sep 8, 2021
View reviewed changes
cibuildwheel/macos.py Outdated Show resolved Hide resolved
@mayeut mayeut requested a review from joerick September 9, 2021 06:18
@henryiii henryiii mentioned this pull request Sep 9, 2021
Closed
joerick
joerick reviewed Sep 9, 2021
View reviewed changes
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I wonder if there's a test we can write that would fail in a similar manner to #818 so that we can verify this. Gimme a few mins...

@joerick
Copy link
Contributor

joerick commented Sep 9, 2021

I've pushed #820 to add a test for this.

@joerick joerick mentioned this pull request Sep 9, 2021
Merged
@henryiii henryiii marked this pull request as draft September 13, 2021 02:49
@joerick
Copy link
Contributor

joerick commented Sep 13, 2021

I think we can close this @henryiii, if you agree with my assessment in #818?

@henryiii
Copy link
Contributor Author

I think so, will look into fixing it in Scikit-Build.

@henryiii henryiii closed this Sep 13, 2021
@henryiii henryiii mentioned this pull request Dec 9, 2021
Closed
@henryiii henryiii deleted the henryiii/fix/macname branch June 6, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerick joerick joerick left review comments

@mayeut mayeut mayeut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henryiii @joerick @mayeut