Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trace Funnel Coresight component #1592

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

rapgenic
Copy link
Contributor

In this PR I implemented a simple graph node for coresight trace funnels.

The TraceFunnel component is quite simple, it reads the number of available channels and enables them all at initialization. The rationale of this choice is that I think that in most of the cases the user wants everything to be working since the beginning.

Channels can be enabled and disabled with the set_enable_channels function, which provides a warning if trying to set more channels than available.

This is show graph output with this patch:

pyocd> show graph
- "board": Board
  - "soc": Mimxrt1176dvmaa
    - "cm7": CortexM
      - DWT
      - FPB
      - ITM
      - TraceFunnel
    - "cm4": CortexM
      - DWT
      - FPB
      - ITM
      - TraceFunnel

Copy link
Member

@flit flit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor requests. The blank line on the end of funnel.py is the only required change.

Thanks for the patch!

pyocd/coresight/funnel.py Outdated Show resolved Hide resolved
pyocd/coresight/funnel.py Show resolved Hide resolved
pyocd/coresight/funnel.py Show resolved Hide resolved
@rapgenic rapgenic requested a review from flit July 26, 2023 13:26
@flit
Copy link
Member

flit commented Jul 26, 2023

Sorry, I just realised… would you mind rebasing and retargeting this to the develop branch? Only fixes are allowed on main. After rebasing, you can edit this PR to modify the merge target branch.

@rapgenic rapgenic changed the base branch from main to develop July 26, 2023 14:03
@rapgenic rapgenic requested a review from flit July 26, 2023 14:04
@flit
Copy link
Member

flit commented Jul 26, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@flit flit merged commit 59d3b42 into pyocd:develop Jul 26, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants