Add Trace Funnel Coresight component #1592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I implemented a simple graph node for coresight trace funnels.
The
TraceFunnel
component is quite simple, it reads the number of available channels and enables them all at initialization. The rationale of this choice is that I think that in most of the cases the user wants everything to be working since the beginning.Channels can be enabled and disabled with the
set_enable_channels
function, which provides a warning if trying to set more channels than available.This is
show graph
output with this patch: