Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax PDSC parsing rules #122

Open
flit opened this issue Oct 5, 2019 · 3 comments
Open

Relax PDSC parsing rules #122

flit opened this issue Oct 5, 2019 · 3 comments

Comments

@flit
Copy link
Member

flit commented Oct 5, 2019

The NordicSemiconductor.nRF_DeviceFamilyPack.8.26.0 PDSC causes CPM to spew 12 of these errors:

Oct 05 11:32:49.098 ERRO when trying to parse component: child element "description" not found in "component" element, Package: nRF_DeviceFamilyPack, Vendor: NordicSemiconductor

It seems like description elements should not cause an error if missing, even though they are technically required by the schema. At least this should be changed to a warning, or better, to a debug message. (I know it doesn't stop the PDSC from being parsed, but it might unduly worry users.)

@theotherjimmy
Copy link
Collaborator

Totally agreed. It should be possible to change a String to an Option<String> and the related code for a single struct to acomplish this.

@flit
Copy link
Member Author

flit commented Oct 6, 2019

Nice, thanks!

@jkrech
Copy link

jkrech commented Oct 7, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants