Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit dims in model config #739

Closed
wd60622 opened this issue Jun 12, 2024 · 0 comments · Fixed by #743
Closed

Explicit dims in model config #739

wd60622 opened this issue Jun 12, 2024 · 0 comments · Fixed by #743

Comments

@wd60622
Copy link
Contributor

wd60622 commented Jun 12, 2024

The model config has implicit dim which reduces model customization

For instance, in model config of the current MMM has implicit dims for variables. For instance, the logistic saturation variables assume to be "channel" but are specified

model_config = {
    ...,
    # Currently written
    "saturation_lam": {"dist": "HalfNormal", "kwargs": {"sigma": 1}}, 
    "saturation_beta": {"dist": "HalfNormal", "kwargs": {"sigma": 1}}, 
    # But is actually
    # "saturation_lam": {"dist": "HalfNormal", "kwargs": {"sigma": 1}, "dims": "channel"},
    # "saturation_beta": {"dist": "HalfNormal", "kwargs": {"sigma": 1}, "dims": "channel"},
    ...,
}

However, this doesn't allow for common parameter between channels. For instance the following would suggest a common shape but different scale of curve:

model_config = {
    ...,
    "saturation_lam": {"dist": "HalfNormal", "kwargs": {"sigma": 1}}, 
    "saturation_beta": {"dist": "HalfNormal", "kwargs": {"sigma": 1}, "dims": "channel"}, 
    ...,
}

Related to #734

Nested / Hierarchical Parameters

In a larger model config, dimensions are required in order to specify differences

For instance,

model_config = {
    ..., 
    "beta": {
        "dist": "Normal", 
        "kwargs": {
            "mu": {"dist": "Normal", "kwargs": {"mu": 0, "sigma": 1}, "dims": "geo"},
            # Very different then this!
            # "mu": {"dist": "Normal", "kwargs": {"mu": 0, "sigma": 1}, "dims": "channel"},
            "sigma": 1,
        }, 
        "dims": ("channel", "geo"), 
    }, 
    ..., 
}

Related to #708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants