From aeb7fafed5e141c00a44610a9647002ab4b35258 Mon Sep 17 00:00:00 2001 From: Carlos Trujillo <59846724+carlangastr@users.noreply.github.com> Date: Sat, 30 Sep 2023 21:31:10 +0000 Subject: [PATCH] Correcting position values --- pymc_marketing/mmm/base.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pymc_marketing/mmm/base.py b/pymc_marketing/mmm/base.py index 2d0581ff..99a8501c 100644 --- a/pymc_marketing/mmm/base.py +++ b/pymc_marketing/mmm/base.py @@ -486,7 +486,7 @@ def compute_channel_contribution_original_scale(self) -> DataArray: ) def _estimate_budget_contribution_fit( - self, channel: str, budget: float, method: str + self, channel: str, budget: float, method: str = "sigmoid" ) -> Tuple: """ Estimate the lower and upper bounds of the contribution fit for a given channel and budget. @@ -615,7 +615,7 @@ def _plot_scenario( ) def plot_budget_scenearios( - self, *, base_data: Dict, method: str, **kwargs + self, *, base_data: Dict, method: str = "sigmoid", **kwargs ) -> plt.Figure: """ Experimental: Plots the budget and contribution bars side by side for multiple scenarios. @@ -657,7 +657,7 @@ def plot_budget_scenearios( for channel, budget in scenario["budget"].items(): if channel != "total": y_fit_lower, y_fit_upper = self._estimate_budget_contribution_fit( - method, channel, budget + method=method, channel=channel, budget=budget ) upper_bound[channel] = y_fit_upper lower_bound[channel] = y_fit_lower