From 886342d317a914f722f94aa06f369b7c24284347 Mon Sep 17 00:00:00 2001 From: Juan Orduz Date: Sat, 24 Aug 2024 05:03:33 +0200 Subject: [PATCH] scaling should be done before hdi computation (#970) --- pymc_marketing/mmm/base.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/pymc_marketing/mmm/base.py b/pymc_marketing/mmm/base.py index bcc59262..f5fc8114 100644 --- a/pymc_marketing/mmm/base.py +++ b/pymc_marketing/mmm/base.py @@ -404,16 +404,18 @@ def plot_posterior_predictive( else: fig = ax.figure + if original_scale: + posterior_predictive_data = apply_sklearn_transformer_across_dim( + data=posterior_predictive_data, + func=self.get_target_transformer().inverse_transform, + dim_name="date", + ) + for hdi_prob, alpha in zip((0.94, 0.50), (0.2, 0.4), strict=True): likelihood_hdi: DataArray = az.hdi( ary=posterior_predictive_data, hdi_prob=hdi_prob )[self.output_var] - if original_scale: - likelihood_hdi = self.get_target_transformer().inverse_transform( - likelihood_hdi - ) - ax.fill_between( x=posterior_predictive_data.date, y1=likelihood_hdi[:, 0],