From 2b9768ab8a77703700464bd6690e4965d79cebca Mon Sep 17 00:00:00 2001 From: "louis.magowan" <59659198+louismagowan@users.noreply.github.com> Date: Fri, 18 Oct 2024 15:15:23 +0200 Subject: [PATCH] fix: Add type ignore args to all sample-args --- pymc_marketing/mlflow.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/pymc_marketing/mlflow.py b/pymc_marketing/mlflow.py index 99867193..ec2ff74d 100644 --- a/pymc_marketing/mlflow.py +++ b/pymc_marketing/mlflow.py @@ -461,7 +461,6 @@ def log_inference_data( def log_evaluation_metrics( - mmm: MMM, y_true: np.ndarray, y_pred: np.ndarray, metrics_to_calculate: list[str] | None = None, @@ -471,8 +470,6 @@ def log_evaluation_metrics( Parameters ---------- - mmm : MMM - The fitted MMM object. y_true : np.ndarray The true values of the target variable. y_pred : np.ndarray @@ -590,7 +587,7 @@ def predict( include_last_observations=self.include_last_observations, original_scale=self.original_scale, var_names=self.var_names, - **self.sample_kwargs, + **self.sample_kwargs, # type: ignore[arg-type] ) elif predict_method == "sample_posterior_predictive": return self.model.sample_posterior_predictive( @@ -600,7 +597,7 @@ def predict( include_last_observations=self.include_last_observations, original_scale=self.original_scale, var_names=self.var_names, - **self.sample_kwargs, + **self.sample_kwargs, # type: ignore[arg-type] ) elif predict_method == "sample_prior_predictive": return self.model.sample_prior_predictive( @@ -947,7 +944,6 @@ def new_fit(self, *args, **kwargs): posterior_preds = self.sample_posterior_predictive(self.X) log_evaluation_metrics( - self, y_true=self.y, y_pred=posterior_preds[ self.output_var[0]