Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support python 3.11 #109

Merged
merged 6 commits into from
Jul 12, 2023
Merged

Add support python 3.11 #109

merged 6 commits into from
Jul 12, 2023

Conversation

juanitorduz
Copy link
Contributor

Just trying and see :)

@juanitorduz
Copy link
Contributor Author

juanitorduz commented Jul 11, 2023 •
edited
Loading

Linter failing because a broken import (maybe related to python/cpython#28618 and GrahamDumpleton/wrapt#196). I'll investigate!

@juanitorduz
Copy link
Contributor Author

In ee40a66 I updated pylint as it was causing the problem. We would have to fix some small changed to make pylint happy.

@juanitorduz
Copy link
Contributor Author

juanitorduz commented Jul 11, 2023 •
edited
Loading

A random test is failing... but does not seem to be related to the python migration.

@juanitorduz
Copy link
Contributor Author

Some stochastic tests like tests/test_pgbart.py::test_normal_sampler sometimes fail because of randomness, shall we add a seed or reduce the precision?

@aloctavodia
Copy link
Member

A seed should do it

@juanitorduz
Copy link
Contributor Author

Given #107, what do you think about a patch release after merging this one? :)

@aloctavodia
Copy link
Member

Makes sense

@aloctavodia aloctavodia merged commit 24eeb1a into pymc-devs:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloctavodia aloctavodia aloctavodia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanitorduz @aloctavodia