Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClickHouseChain batch inserting assumes that all calls to .append() pass similar dicts as the first call #74

Open
michaelosthege opened this issue Dec 20, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@michaelosthege
Copy link
Member

The batch inserting mechanism creates the insert query based on the composition of draw and stats dicts of the very first call to .append().

Later on it assumes that all further calls have the identical composition of dictionaries.

ClickHouse does support sparse insert queries, but the batch inserting mechanism will have to be adapted to check if the composition changed, and if needed commit the queue and create a new query.

@michaelosthege michaelosthege added the bug Something isn't working label Dec 20, 2022
michaelosthege added a commit that referenced this issue Dec 20, 2022
michaelosthege added a commit that referenced this issue Dec 20, 2022
@michaelosthege michaelosthege changed the title ClickHouseChain batch inserting assumes that all calls to .append() pass similar dics as the first call ClickHouseChain batch inserting assumes that all calls to .append() pass similar dicts as the first call Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant