Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update validate_systs.py to run on a patchset instead. #43

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kratsg
Copy link

@kratsg kratsg commented Apr 13, 2022

No description provided.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Apr 13, 2022

This pull request introduces 2 alerts when merging cf947cd into fe152dd - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Base: 91.66% // Head: 91.66% // No change to project coverage 👍

Coverage data is based on head (60800a0) compared to base (60800a0).
Patch has no changes to coverable lines.

❗ Current head 60800a0 differs from pull request most recent head 25aff4a. Consider uploading reports for the commit 25aff4a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files           3        3           
  Lines          12       12           
=======================================
  Hits           11       11           
  Misses          1        1           
Flag Coverage Δ
unittests-3.10 91.66% <0.00%> (ø)
unittests-3.7 90.90% <0.00%> (ø)
unittests-3.8 91.66% <0.00%> (ø)
unittests-3.9 91.66% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kratsg I bumped things just to turn on the CI again and to get it to pass pre-commit checks. Can you add some text to the PR body description and then we can iterate if you think anything else needs to be done here?

@@ -206,33 +211,32 @@
)
def outlier_plot(signal_template, v_max, x_var, y_var, x_label, y_label):

patches = [json.load(open(x)) for x in glob.glob("patch*.json")]
patchset = pyhf.PatchSet(json.load(open("patchsets_SlepSlep.json")))

Check warning

Code scanning / CodeQL

File is not always closed

File is opened but is not closed.
listOfPatches = glob.glob("patch*.json")
spec_sig = json.load(open(listOfPatches[0]))
spec_bkg = json.load(open("BkgOnly.json"))
spec_bkg = json.load(open("bkgonly.json"))

Check warning

Code scanning / CodeQL

File is not always closed

File is opened but is not closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants