-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update validate_systs.py to run on a patchset instead. #43
base: main
Are you sure you want to change the base?
Conversation
This pull request introduces 2 alerts when merging cf947cd into fe152dd - view on LGTM.com new alerts:
|
Codecov ReportBase: 91.66% // Head: 91.66% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 3 3
Lines 12 12
=======================================
Hits 11 11
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kratsg I bumped things just to turn on the CI again and to get it to pass pre-commit checks. Can you add some text to the PR body description and then we can iterate if you think anything else needs to be done here?
08ce379
to
25aff4a
Compare
@@ -206,33 +211,32 @@ | |||
) | |||
def outlier_plot(signal_template, v_max, x_var, y_var, x_label, y_label): | |||
|
|||
patches = [json.load(open(x)) for x in glob.glob("patch*.json")] | |||
patchset = pyhf.PatchSet(json.load(open("patchsets_SlepSlep.json"))) |
Check warning
Code scanning / CodeQL
File is not always closed
listOfPatches = glob.glob("patch*.json") | ||
spec_sig = json.load(open(listOfPatches[0])) | ||
spec_bkg = json.load(open("BkgOnly.json")) | ||
spec_bkg = json.load(open("bkgonly.json")) |
Check warning
Code scanning / CodeQL
File is not always closed
No description provided.