Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Test version is slow only on MacOS #14

Closed
matthewfeickert opened this issue Mar 28, 2020 · 1 comment · Fixed by #17
Closed

bug: Test version is slow only on MacOS #14

matthewfeickert opened this issue Mar 28, 2020 · 1 comment · Fixed by #17
Labels
bug Something isn't working

Comments

@matthewfeickert
Copy link
Member

matthewfeickert commented Mar 28, 2020

In the CI

def test_version(script_runner):
command = "pyhf-validation --version"
start = time.time()
ret = script_runner.run(*shlex.split(command))
end = time.time()
elapsed = end - start
assert ret.success
assert hfval.__version__ in ret.stdout
assert ret.stderr == ""
# make sure it took less than a second
assert elapsed < 1.0

will often fail as it will take longer than 1 second for test_version to complete but only on MacOS. I am not sure why it is only MacOS, but this should be resolved.

c.f. PR #9

@matthewfeickert matthewfeickert added the bug Something isn't working label Mar 28, 2020
@kratsg
Copy link

kratsg commented Jun 23, 2020

Just saw this.. sorry. MacOS has a longer PYTHONPATH included by default, and I think you might see some extra slowdown b/c of that... I'd check the pythonpath, and other env variable settings to see where the slowdown is (executable lookup or actual code execution?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants