-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segfault on test suite with 'clifford/test/test_cga.py::test_round_from_center_radius_init' for version 'v1.3.0' on OSX #376
Comments
Does this happen every time? If you, can you check if |
Happens every time yes, is fine on master. |
Test in question is: clifford/clifford/test/test_cga.py Lines 84 to 92 in 2da66d3
|
Can you run with python fault handling enabled so that we get a traceback? |
@eric-wieser sure, could you point me at some documentation on how to do that? |
It looks like its supposed to be enabled by default... https://docs.pytest.org/en/stable/usage.html#fault-handler |
Using |
Yeah, I think this didn't really get us any further:
FWIW: I also tried to use
|
Can you diagnose which line is failing by inserting print statements between each line of the test? |
So, I have some news on this. It seems like
|
This is the debugging patch which is responsible for the output lines:
|
Looks like it might be the line
|
Thanks, that gives me plenty to work with. I wonder whether this is actually a numpy incompatibility. |
@eric-wieser that was a good hunch, I tried with Numpy 1.18.5 and the test did not segfault. |
I imagine this means that this reproduces on windows |
And my guess would be that the bug was fixed in clifford by a1b1ba3 |
Either way, thanks for the dive into the cause - I've reported a bug against numpy, which I might take a look at next time I put on my numpy hat. |
@eric-wieser shall we keep the issue open? I made the integration tests pass, for now: |
I am on OSX Version 10.15.7 -- Steps to reproduce:
The text was updated successfully, but these errors were encountered: