Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should _settings._eps be used in printing? #368

Open
tBuLi opened this issue Oct 14, 2020 · 1 comment
Open

Should _settings._eps be used in printing? #368

tBuLi opened this issue Oct 14, 2020 · 1 comment

Comments

@tBuLi
Copy link

tBuLi commented Oct 14, 2020

In the __str__ method of MultiVector, there is the following line:

if abs(coeff) < _settings._eps:
    continue  # too small to print

But this doesn't feel right to me since e.g. I'm trying to compute inverses so I need _eps to be really tiny, but that shouldn't impact printing. I have the feeling _settings._print_precision should be used here just like everywhere else in this method but since it isn't, perhaps there is a reason I'm missing?

If it is a bug let me know, I can make a quick PR.

@eric-wieser
Copy link
Member

See also #356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants