-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alpha Vantage as data source? #389
Comments
Before releasing our own independent solution, we expect to |
can only support this. have been using alpha vantage for a while now. Found their API is reliable and the data quality is good. |
What is the pandas_datareader policy on requiring the user to get an API key |
There is already precedent with Enigma https://github.com/pydata/pandas-datareader/blob/master/pandas_datareader/enigma.py We will request adding them to Travis and ReadTheDocs |
Maybe the vendor should be contacted, and be asked to contribute |
its a free api key. I am not sure if they would write it. |
I didn't find vendor implementation, but there is https://github.com/RomelTorres/alpha_vantage |
Hello there, I maintain the python wrapper as much as I can, usually the vendor contacts me whenever there is something new, to make sure I update it. I don't think AlphaVantage itself will release a python wrapper for its API call. |
@RomelTorres Might you consider adding your codebase into |
@gliptak Hi, I could do it, but how would be the best way to tackle that? Should I add the original library as a dependency and then send a PR to you guys? or should I port the code base only (That'd mean two things to maintain)?. Also, what do you guys want from alpha vantage, everything? or just the stock information? BR Romel |
@RomelTorres First a disclaimer, I'm not an member/committer for My understanding is that the preference would be to not rely on a library (here is the current list of dependencies https://github.com/pydata/pandas-datareader/blob/master/setup.py#L28) After you could consider using As for the data types, there is already stock and FX data (at various timeframes) from other sources, but you might be the first with cryptocurrency data :) I think many users generate technical indicators from the "raw" data. @davidastephens @jreback Please comment. Thanks |
@RomelTorres have you had a chance to look into this? If so, let me know if you'd like any assistance. If not, I have some time to work on it now and was going to base the readers off of your library. |
Hi @addisonlynch I haven't had much time to be honest (a lot of projects going on atm) If you want you can base it off mine. |
I created a pull which implements most of the API. There are some questsions/topics for discussion in the comment. Let me know what you think. |
https://www.alphavantage.co/documentation/
Requires an API key
The text was updated successfully, but these errors were encountered: