Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard dependency on keyring #610

Open
BenjamenMeyer opened this issue Jun 29, 2016 · 3 comments
Open

Remove hard dependency on keyring #610

BenjamenMeyer opened this issue Jun 29, 2016 · 3 comments

Comments

@BenjamenMeyer
Copy link

BenjamenMeyer commented Jun 29, 2016

keyring now as a hard dependency on secretstorage which has a hard dependency on dbus-python and on Debian python-dbus (a system level package). This does not make sense for WSGI apps where the keyring will never be used, thus having a hard dependency on keyring while nice for the command-line interface is now problematic for APIs.

If keyring is installed, then use it. But if not, then please disable storage.

Filing this here in case keyring doesn't resolve this per jaraco/keyring#236; issues has already been field with secretstorage twice and they refuse to break the hard dependency at that level.

@BenjamenMeyer BenjamenMeyer changed the title Remove hard dependency on secretstorage Remove hard dependency on keyring Jun 29, 2016
@BenjamenMeyer BenjamenMeyer reopened this Jun 29, 2016
@BenjamenMeyer
Copy link
Author

Initially filed this as being directly related to secretstorage as I had thought that was the being directly pulled in by pyrax, however it's a dependency of a dependency so I updated this accordingly.

@briancurtin
Copy link
Contributor

Do you want this to depend on whether keyring ends up making their change, or do you want to just change this anyway?

@BenjamenMeyer
Copy link
Author

BenjamenMeyer commented Jun 29, 2016

@briancurtin having it depend on whether or not keyring makes the change at their level is okay with me

Either way, pyrax should not fail to install if dbus is not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants