Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pin/unpin & pinned_comments #1888

Merged
merged 4 commits into from
Sep 1, 2024
Merged

Add pin/unpin & pinned_comments #1888

merged 4 commits into from
Sep 1, 2024

Conversation

marci4
Copy link
Contributor

@marci4 marci4 commented Aug 26, 2024

Fixes #1877

@marci4
Copy link
Contributor Author

marci4 commented Aug 26, 2024

I am unsure what I have to do to a label after I created the PR.

@dimitarOnGithub
Copy link

Maybe a check if the instance is hosted could be added, raise an error otherwise (feature is not currently implemented for Cloud AFAIK), but I don't know if any third party apps might actually offer those end points and I'm just being pedantic.

@adehad I'd say this PR is a good candidate for a quick and easy merge

Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for this high quality contribution

@adehad adehad merged commit afbced5 into pycontribs:main Sep 1, 2024
15 checks passed
@marci4 marci4 deleted the feat/pin branch September 2, 2024 07:29
Wojtini pushed a commit to Wojtini/jira that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Pin/Unpin and accessing pinned comments
3 participants