Implemented pybricks protocol v1.4.0 #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: added ble-pybricks-service tests fix: improved ArrayBuffer deep equality check
dlech
reviewed
Oct 13, 2024
|
Hi! I wanted to check in and see how the review is going on this PR. If there’s anything specific I can assist with or if you have any feedback, just let me know. |
* Update for changed StartUserProgram command semantics * Added new capability flags and fixed-purpose slot definitions * Update for new start REPL command * Updated StartUserProgram command and Status event for slots * Added new AppData command and event
|
There was still quite a bit to do and I had some time to work on it, so I went ahead and fixed it up. |
|
Thanks both of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding pybricks protocol v1.4.0 handling as a first step on to merge hubcenter feature in #2315.