Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default number of cascade levels to 6 everywhere in the project #387

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

sidekock
Copy link
Contributor

The default number of cascades is set to 6 both in the code and the examples

@sidekock sidekock linked an issue Jul 18, 2024 that may be closed by this pull request
@sidekock sidekock self-assigned this Jul 18, 2024
@sidekock sidekock added the enhancement New feature or request label Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (1629859) to head (77303ab).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   83.64%   83.64%           
=======================================
  Files         159      159           
  Lines       12598    12598           
=======================================
  Hits        10537    10537           
  Misses       2061     2061           
Flag Coverage Δ
unit_tests 83.64% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sidekock sidekock requested a review from dnerini July 18, 2024 11:54
Copy link
Member

@dnerini dnerini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@dnerini dnerini merged commit d224015 into master Jul 18, 2024
10 checks passed
@dnerini dnerini deleted the reduce_default_number_of_cascade_levels_to_6 branch July 18, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Reduce default number of cascade levels to 6
2 participants