Add lambert_conformal_conic projection #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pysteps.io.exporters._convert_proj4_to_grid_mapping()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 83.52% 83.64% +0.11%
==========================================
Files 159 159
Lines 12575 12598 +23
==========================================
+ Hits 10503 10537 +34
+ Misses 2072 2061 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
code coverage is complaining, could you maybe include a simple test for the new lines of code that you've added? |
|
I am on it. The test function will be added and should be compatible with different projections strings. To achieve this, I need the projection strings and expected output for the other projections (i.e., "stere" and "aea").
if you have pro4str for the 2 projection types mentioned above, that would be great ;)
function: pysteps_io.exporters._convert_proj4_to_grid_mapping()
From: "Daniele Nerini" ***@***.***>
To: "pySTEPS/pysteps" ***@***.***>
Cc: "FelixE91" ***@***.***>, "Author" ***@***.***>
Sent: Wednesday, July 17, 2024 2:06:54 PM
Subject: Re: [pySTEPS/pysteps] Add lambert_conformal_conic projection (PR #380)
code coverage is complaining, could you maybe include a simple test for the new lines of code that you've added?
—
Reply to this email directly, [ #380 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/BJ33FMF6PLLSTQUCGQ2IYZTZMZM55AVCNFSM6AAAAABLAIPZ2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTGE3DENBQGY | unsubscribe ] .
You are receiving this because you authored the thread. Message ID: ***@***.***>
|
Function added to tests/test_exporters.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lambert_conformal_conic projection pysteps.io.exporters._convert_proj4_to_grid_mapping()
Fix to issue #378