Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure netcdf exporters can handle list of timesteps #369

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

RubenImhoff
Copy link
Contributor

This PR ensures that the netcdf exporters can handle a list of timesteps next to just an integers number of timesteps. One of pysteps' functionalities is that you can give it specific output timesteps for which the nowcasts should be stored, but it was not yet possible to store these output timesteps as such in a netCDF. This PR tries to fix that.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.52%. Comparing base (1525178) to head (2abd113).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   83.33%   83.52%   +0.18%     
==========================================
  Files         161      159       -2     
  Lines       12370    12575     +205     
==========================================
+ Hits        10309    10503     +194     
- Misses       2061     2072      +11     
Flag Coverage Δ
unit_tests 83.52% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RubenImhoff RubenImhoff requested a review from dnerini July 3, 2024 16:13
Copy link
Member

@dnerini dnerini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution @RubenImhoff ! I left few very minor comments

pysteps/io/exporters.py Outdated Show resolved Hide resolved
pysteps/io/exporters.py Show resolved Hide resolved
pysteps/io/exporters.py Outdated Show resolved Hide resolved
@dnerini dnerini merged commit 953f799 into master Jul 11, 2024
10 checks passed
@RubenImhoff RubenImhoff deleted the netcdf_exporter_timesteps branch July 18, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants