Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Record coverage in subprocesses as well #2556

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

stefan6419846
Copy link
Collaborator

No description provided.

@stefan6419846 stefan6419846 added the nf-ci Non-functional change: Continuous Integration label Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (98aa974) to head (e7a1eb1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2556   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files          52       52           
  Lines        8741     8741           
  Branches     1590     1590           
=======================================
  Hits         8426     8426           
  Misses        186      186           
  Partials      129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator Author

Somehow GitHub does not seem to pick up the configuration - running COVERAGE_PROCESS_START=pyproject.toml python -m pytest tests --cov=pypdf --cov-append -n auto -vv locally does indeed show a difference.

@stefan6419846
Copy link
Collaborator Author

Assumption: We need to use more recent versions of some dependencies to fix this as the latest version would work this way locally and in another project of mine.

@pubpub-zz
Copy link
Collaborator

do you have any ideas of which modules needs to be updated and to which minimum version?

@stefan6419846
Copy link
Collaborator Author

Most likely coverage.py and/or pytest-cov, but I have not yet verified this.

@pubpub-zz pubpub-zz marked this pull request as draft June 7, 2024 20:46
@stefan6419846 stefan6419846 marked this pull request as ready for review November 3, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nf-ci Non-functional change: Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants