Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Flexible API for Multiple Testing Corrections #484

Open
s3alfisc opened this issue Jun 6, 2024 · 0 comments
Open

More Flexible API for Multiple Testing Corrections #484

s3alfisc opened this issue Jun 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@s3alfisc
Copy link
Member

s3alfisc commented Jun 6, 2024

Context

Currently, it is only possible to control for multiple testing for hypothesis of the same parameter, against the same null.

from pyfixest.estimation import feols
from pyfixest.utils import get_data
from pyfixest.multcomp import rwolf

data = get_data().dropna()
fit = feols("Y ~ Y2 + X1 + X2", data=data)
rwolf(fit.to_list(), "X1", reps=9999, seed=123)

E.g. for a set of regression models $s = 1, ..., S$, we can only test that $\beta_{ks} = 0$ for a parameter k. In the example above, the parameter to be tested, "X1", needs to be fixed across models. It is not possible to e.g. test more complex hypotheses, as e.g. $\beta_{1,1} = 0$, $\beta_{1,2} = 0$, etc.

To Do

  • Define an API that allows users to test more complex hypotheses via bonferroni() and rwolf(). We can draw some inspiration from the rwolf2 Stata module.
  • Then, implement it =)
@s3alfisc s3alfisc added the enhancement New feature or request label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant