Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better check for global.Buffer #104

Open
mrx8 opened this issue Feb 4, 2019 · 1 comment
Open

better check for global.Buffer #104

mrx8 opened this issue Feb 4, 2019 · 1 comment

Comments

@mrx8
Copy link

mrx8 commented Feb 4, 2019

clone.js line 106:
} else if (useBuffer && Buffer.isBuffer(parent)) {

can you at least check if Buffer.isBuffer is a function ?
I ended up with a failing clone.js in an Angular project, becaus some other (possibly errorneus package) put an array named "Buffer" in global.
@Akryum Akryum mentioned this issue Mar 25, 2019
Closed
@pvorb
Copy link
Owner

pvorb commented Aug 6, 2019

Hi, can you provide a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pvorb @mrx8