[MAINT]: GH worflow actions update #2218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3be0b20.
|
I'll close this PR now that everything is working properly, even thou it can be used as an update of the action dependencies. |
echedey-ls
changed the title
AdamRJensen
added a commit
to AdamRJensen/pvlib-python
that referenced
this pull request
Sep 25, 2024
kandersolar
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Update to actions/setup-python@v5 * Update to actions/checkout@v4 * Bring up to #2218 * Address reviewer comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.1. Tries to fix #2211 as other two people have fixed the same problem by removing the login shell (bash -lflag) from the workflows.2. Attempts to remove all custom bashes; includes-elflags forasv_check.yml(-eflag docs, is the default for shells).3. Updates actions versions (I don't really know if that helps maintenance in the long run, just my preference of following the trends)
I'm open to address only #2211 by updating the pytest workflow shells.