Remove warning message for num_threads in pvlib.spa
#2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandersolar
changed the title
num_threads in pvlib.spanum_threads in pvlib.spa
cwhanse
approved these changes
Aug 25, 2024
|
If I remember correctly, @AdamRJensen suggested we get rid of this warning entirely. I'm inclined to agree. The situation in question (number of threads larger than number of timestamps) is not inherently problematic. What is the user supposed to "fix" to make the warning go away? I plan to modify this PR to just remove the warning. |
|
No objection from me |
kandersolar
changed the title
num_threads in pvlib.spanum_threads in pvlib.spa
AdamRJensen
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] Updates entries indocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.Edit: this PR now removes, instead of edits, the mentioned warning. Original text below:
The numba SPA implementation uses multithreading by default. When the specified number of threads is larger than the number of given timestamps, a warning is emitted indicating that the number of used threads is being reduced to match the input timestamps. However, the message mixes two styles of interpolation (old
%sstyle and.formatstyle) and thus produces a faulty message with the interpolation placeholder still present:This PR fixes the interpolation so that it would then look something like this: