Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pvlib.atmosphere.first_solar_spectral_correction #2131

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove pvlib.atmosphere.first_solar_spectral_correction #2131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1b77b8
Remove `pvlib.atmosphere.first_solar_spectral_correction`
echedey-ls Jul 13, 2024
9d685e5
Remove unneeded imports
echedey-ls Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/sphinx/source/reference/airmass_atmospheric.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ Airmass and atmospheric models
atmosphere.pres2alt
atmosphere.alt2pres
atmosphere.gueymard94_pw
atmosphere.first_solar_spectral_correction
atmosphere.bird_hulstrom80_aod_bb
atmosphere.kasten96_lt
atmosphere.angstrom_aod_at_lambda
Expand Down
9 changes: 0 additions & 9 deletions pvlib/atmosphere.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@

import numpy as np
import pandas as pd
import pvlib

from pvlib._deprecation import deprecated

APPARENT_ZENITH_MODELS = ('simple', 'kasten1966', 'kastenyoung1989',
'gueymard1993', 'pickering2002')
Expand Down Expand Up @@ -336,12 +333,6 @@ def gueymard94_pw(temp_air, relative_humidity):
return pw


first_solar_spectral_correction = deprecated(
since='0.10.0',
alternative='pvlib.spectrum.spectral_factor_firstsolar'
)(pvlib.spectrum.spectral_factor_firstsolar)


def bird_hulstrom80_aod_bb(aod380, aod500):
"""
Approximate broadband aerosol optical depth.
Expand Down
6 changes: 0 additions & 6 deletions pvlib/tests/test_atmosphere.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,6 @@ def test_gueymard94_pw():
assert_allclose(pws, expected, atol=0.01)


def test_first_solar_spectral_correction_deprecated():
with pytest.warns(pvlibDeprecationWarning,
match='Use pvlib.spectrum.spectral_factor_firstsolar'):
atmosphere.first_solar_spectral_correction(1, 1, 'cdte')


def test_kasten96_lt():
"""Test Linke turbidity factor calculated from AOD, Pwat and AM"""
amp = np.array([1, 3, 5])
Expand Down
Loading