You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In [156]: clear_samples=clearsky.detect_clearsky(ghi, cs['ghi'], cs.index, 10)
---------------------------------------------------------------------------ValueErrorTraceback (mostrecentcalllast)
<ipython-input-156-a86cb0f5cb3e>in<module>---->1clear_samples=clearsky.detect_clearsky(ghi, cs['ghi'], cs.index, 10)
~/checkouts/readthedocs.org/user_builds/pvlib-python/checkouts/stable/pvlib/clearsky.pyindetect_clearsky(measured, clearsky, times, infer_limits, window_length, mean_diff, max_diff, lower_line_length, upper_line_length, var_diff, slope_dev, max_iterations, return_components)
823iflen(times) <samples_per_window:
824raiseValueError(f"times has only {len(times)} entries, but it must \--> 825 have at least {samples_per_window} entries")
826827# generate matrix of integers for creating windows with indexingValueError: timeshasonly30entries, butitmusthaveatleast50entries
Presumably the problem is that this code is passing the value 10 by position to the new infer_limits parameter added in #1784 instead of to window_length like it used to. I expect it would be fixed by editing that line in clearsky.rst to specify the parameter by name: window_length=10.
The text was updated successfully, but these errors were encountered:
I'd like to tackle this issue.
Seems like your fix suggestion worked. Output after running make html:
I have a question about PR's since this is only my second issue. What is the procedure for updating my fork of the repo as I move from issue to issue? Should I delete each such forked repo and create a new fork for every new issue (a little inefficient). Right now my fork is actually ahead of main by 10 commits, I think because a PR gets squashed into 1 commit. If I just start building atop of this, this will most likely cause a problem since those commits have already been incorporated.
The clear-sky docs page has an issue:
Presumably the problem is that this code is passing the value
10
by position to the newinfer_limits
parameter added in #1784 instead of towindow_length
like it used to. I expect it would be fixed by editing that line in clearsky.rst to specify the parameter by name:window_length=10
.The text was updated successfully, but these errors were encountered: