Fix preserve param default #858
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discovered when running test suite with ruby:3.2 image on docker
v3 is deprecated and produces a warning message
removed cops are provided by gems not explicitly installed they seem to be installed using the setup ruby action, but not when testing in a ruby docker image either way, they are covered by enabling newcops
h0tw1r3
force-pushed
the
fix-preserve-param-default
branch
from
25dbac5
to
fa0f077
Compare
e-gris
reviewed
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
27086b7 originally changed the preserve default to :on-failure, but 2e3ba3b erroneously changed it from on-failure to always, and the spec tests added in 94b87cc never caught the discrepancy because the class abruptly exits due to invalid parameters in the tests
PR parent branch, only the commit fa0f077 is unique to this PR