diff --git a/.gitignore b/.gitignore index 7c9210fe..988dcbbe 100644 --- a/.gitignore +++ b/.gitignore @@ -26,5 +26,3 @@ .envrc /inventory.yaml /spec/fixtures/litmus_inventory.yaml -/acceptance/junit -/acceptance/log \ No newline at end of file diff --git a/acceptance/Gemfile b/acceptance/Gemfile index 1b28744f..e7976986 100644 --- a/acceptance/Gemfile +++ b/acceptance/Gemfile @@ -24,5 +24,5 @@ gem "beaker-puppet", *location_for(ENV['BEAKER_PUPPET_VERSION'] || 'https://gith gem "beaker-docker", *location_for(ENV['BEAKER_DOCKER_VERSION'] || '~> 0') gem "beaker-vagrant", *location_for(ENV['BEAKER_VAGRANT_VERSION'] || '~> 0') gem "beaker-vmpooler", *location_for(ENV['BEAKER_VMPOOLER_VERSION'] || '~> 1') -gem "beaker-hostgenerator", *location_for(ENV['BEAKER_HOSTGENERATOR_VERSION'] || '~> 1') +gem "beaker-hostgenerator", *location_for(ENV['BEAKER_HOSTGENERATOR_VERSION'] || '~> 2') gem "beaker-abs", *location_for(ENV['BEAKER_ABS_VERSION'] || '~> 0') diff --git a/manifests/osfamily/redhat.pp b/manifests/osfamily/redhat.pp index 2d7bdb56..30c075ae 100644 --- a/manifests/osfamily/redhat.pp +++ b/manifests/osfamily/redhat.pp @@ -19,18 +19,15 @@ } 'Amazon': { $major_version = $facts['os']['release']['major'] - if ("${major_version}" == '2') { - $amz_el_version = '7' - } - else { - $amz_el_version = '6' + $amz_el_version = "${major_version}" ? { + '2' => '7', + /^(2017|2018)$/ => '6', + default => $major_version, } - if ("${amz_el_version}" =~ /^(\A6\z|\A7\z)/) { - $platform_and_version = "el/${amz_el_version}" - } - else { - $platform_and_version = "amazon/${major_version}" + $platform_and_version = "${amz_el_version}" ? { + /^(6|7)$/ => "el/${amz_el_version}", + default => "amazon/${amz_el_version}", } } default: { diff --git a/spec/classes/puppet_agent_osfamily_redhat_spec.rb b/spec/classes/puppet_agent_osfamily_redhat_spec.rb index bea3e209..8fe4d231 100644 --- a/spec/classes/puppet_agent_osfamily_redhat_spec.rb +++ b/spec/classes/puppet_agent_osfamily_redhat_spec.rb @@ -21,7 +21,7 @@ } end - [['Rocky', 'el/8', 8], ['AlmaLinux', 'el/8', 8], ['Fedora', 'fedora/f36', 36], ['CentOS', 'el/7', 7], ['Amazon', 'el/6', 2017], ['Amazon', 'el/7', 2]].each do |os, urlbit, osmajor| + [['Rocky', 'el/8', 8], ['AlmaLinux', 'el/8', 8], ['Fedora', 'fedora/f36', 36], ['CentOS', 'el/7', 7], ['Amazon', 'el/6', 2017], ['Amazon', 'el/6', 2018], ['Amazon', 'el/7', 2], ['Amazon', 'amazon/2023', 2023]].each do |os, urlbit, osmajor| context "with #{os} and #{urlbit}" do let(:facts) do override_facts(super(), os: { name: os, release: { major: osmajor, }, })