Add files to include in tarball #9454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Puppet relied on the in-house Packaging library to build all artifacts related to Puppet. Puppet moved away from using Packaging to build gems in 867ce9c, which also removed the files key used to build tarballs. This commit re-adds the files key (as a list instead of a string, as recommended by Packaging) to enable the packaging:tar Rake task, which builds source tarballs of Puppet.
|
Tests are broken due to an unrelated issue, should be addressed in #9455 |
joshcooper
approved these changes
Aug 27, 2024
|
Should this be backported to 7.x? |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Puppet relied on the in-house Packaging library to build all artifacts related to Puppet. Puppet moved away from using Packaging to build gems in 867ce9c, which also removed the files key used to build tarballs.
This commit re-adds the files key (as a list instead of a string, as recommended by Packaging) to enable the packaging:tar Rake task, which builds source tarballs of Puppet.