Update deprecated Beaker methods #9236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhashizume
force-pushed
the
PA-5022/main/beaker-deprecated
branch
2 times, most recently
from
e6deadc
to
c2d49a1
Compare
mhashizume
force-pushed
the
PA-5022/main/beaker-deprecated
branch
2 times, most recently
from
9fc1eb4
to
a81f2c0
Compare
mhashizume
force-pushed
the
PA-5022/main/beaker-deprecated
branch
from
a81f2c0
to
d2e5496
Compare
|
jenkins please test this on redhat7-64a |
mhashizume
force-pushed
the
PA-5022/main/beaker-deprecated
branch
from
d2e5496
to
71ce4ed
Compare
|
jenkins please test this on redhat7-64a |
1 similar comment
|
jenkins please test this on redhat7-64a |
tvpartytonight
approved these changes
Feb 6, 2024
The assert_no_match method in Beaker was long deprecated then eventually removed altogether in voxpupuli/beaker@6282311 This commit updates all instances of assert_no_match in Puppet's Beaker tests with refute_match.
Previously in Beaker, you could use standalone stdout and stderr methods to access output from remote machines. These methods were deprecated in 2013 with voxpupuli/beaker@28b2510 and dropped entirely in voxpupuli/beaker@73a31c7. This commit removes these methods from puppet tests in favor of calling stdout and stderr methods on Result objects.
This commit removes a conditional dependent on Passenger support, which was dropped in Puppet 6.
mhashizume
force-pushed
the
PA-5022/main/beaker-deprecated
branch
from
71ce4ed
to
0037a8d
Compare
|
LGTM did you want to re-run PR testing? Or just merge? |
|
I think that the previous PR testing only showed those two errors solved by #9244 , so I think we are good to merge. |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates several deprecated Beaker methods that were removed entirely in Beaker 5. This is in preparation for moving Puppet to using Beaker 5 for tests.