(PUP-11985) correctly enable module:stream without default profile with dnfmodule #9138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I would have loved to create a Jira for this, but it seems new issues for "PUP" cannot be created on https://puppet.atlassian.net and https://tickets.puppetlabs.com is just a redirect 😿 |
evgeni
force-pushed
the
enable-right-stream
branch
from
207a727
to
c16adb6
Compare
|
Opened #9142 |
evgeni
changed the title
the old code would work correctly for ensure => present, but not for ensure => 'some_stream', as dnf does include the whole module spec in the error message and the old regex didn't match anymore. ``` Error: Problems in request: broken groups or modules: 389-ds Error: Problems in request: broken groups or modules: 389-ds:1.4 ```
evgeni
force-pushed
the
enable-right-stream
branch
from
c16adb6
to
9fe028d
Compare
|
Nothing in this PR touches Windows related code, so 🤷♀️ |
joshcooper
added
triaged
joshcooper
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the old code would work correctly for ensure => present, but not for ensure => 'some_stream', as dnf does include the whole module spec in the error message and the old regex didn't match anymore.