Fix Puppet::HTTP::Client example with system store
#9116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
smortex
changed the title
Puppet::HTTP::Client example with system store
The evolution of that part of the code has seen multiple iterations, and the doc does not reflect the current usage so fix it. While here, also fix the wrong variable name typo.
smortex
force-pushed
the
fix-docs-http-client-usage
branch
from
72958f0
to
c1b0085
Compare
joshcooper
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Thanks @smortex! Yes indeed. Originally I had wanted to only use keyword arguments, but had to switch to an options hash to maintain compatibility with puppetserver's http client implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The evolution of that part of the code has seen multiple iterations, and
the doc does not reflect the current usage so fix it.
While here, also fix the wrong variable name typo.