(PUP-11945) Add patches for File and Dir exists? methods #9113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthorn42
force-pushed
the
maint/main/PUP-11945_add_monkey_patch_for_exists
branch
from
968d7e7
to
640d6e4
Compare
joshcooper
reviewed
Sep 27, 2023
cthorn42
force-pushed
the
maint/main/PUP-11945_add_monkey_patch_for_exists
branch
from
640d6e4
to
d10e646
Compare
We should handle cases where the deprecated exists? methods are called for File or Dir, and give a warning but still allow things to proceed.
cthorn42
force-pushed
the
maint/main/PUP-11945_add_monkey_patch_for_exists
branch
from
d10e646
to
1341b92
Compare
joshcooper
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should handle cases where the deprecated exists? methods are called for File or Dir, and give a warning but still allow things to proceed.