Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PUP-11667) document version range support for apt, yum and dnf #8943

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

evgeni
Copy link
Contributor

@evgeni evgeni commented Oct 29, 2022

No description provided.

@evgeni evgeni requested a review from a team as a code owner October 29, 2022 08:22
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

@joshcooper
Copy link
Contributor

Thanks for your PR @evgeni Can you provide steps to show how this change corrects the documentation?

@evgeni
Copy link
Contributor Author

evgeni commented Sep 13, 2023

The rendered docs for the package type (eg https://www.puppet.com/docs/puppet/7/types/package.html) should list apt, dnf and yum with version_ranges in the "Supported features" list.

@joshcooper
Copy link
Contributor

The diff of puppet doc -r type before and after looks correct:

1734c1734
< apt              |             | *X*      |              | *X*             | *X*         |                  | *X*       |               |                  |            |                   | *X*           | *X*         |                | *X*         | *X*              |
---
> apt              |             | *X*      |              | *X*             | *X*         |                  | *X*       |               |                  |            |                   | *X*           | *X*         | *X*            | *X*         | *X*              |
1738c1738
< dnf              |             |          | *X*          | *X*             | *X*         |                  | *X*       |               |                  |            |                   | *X*           | *X*         |                | *X*         | *X*              |
---
> dnf              |             |          | *X*          | *X*             | *X*         |                  | *X*       |               |                  |            |                   | *X*           | *X*         | *X*            | *X*         | *X*              |
1771c1771
< yum              |             |          | *X*          | *X*             | *X*         |                  | *X*       |               |                  |            |                   | *X*           | *X*         |                | *X*         | *X*              |
---
> yum              |             |          | *X*          | *X*             | *X*         |                  | *X*       |               |                  |            |                   | *X*           | *X*         | *X*            | *X*         | *X*              |
2038c2038
<     * Supported features: `holdable`, `install_options`, `installable`, `purgeable`, `uninstallable`, `upgradeable`, `versionable`, `virtual_packages`.
---
>     * Supported features: `holdable`, `install_options`, `installable`, `purgeable`, `uninstallable`, `upgradeable`, `version_ranges`, `versionable`, `virtual_packages`.
2071c2071
<     * Supported features: `install_only`, `install_options`, `installable`, `purgeable`, `uninstallable`, `upgradeable`, `versionable`, `virtual_packages`.
---
>     * Supported features: `install_only`, `install_options`, `installable`, `purgeable`, `uninstallable`, `upgradeable`, `version_ranges`, `versionable`, `virtual_packages`.
2400c2400
<     * Supported features: `install_only`, `install_options`, `installable`, `purgeable`, `uninstallable`, `upgradeable`, `versionable`, `virtual_packages`.
---
>     * Supported features: `install_only`, `install_options`, `installable`, `purgeable`, `uninstallable`, `upgradeable`, `version_ranges`, `versionable`, `virtual_packages`.

@evgeni Could you rebase your commit on 7.x?

@evgeni evgeni changed the base branch from main to 7.x September 27, 2023 17:08
@evgeni
Copy link
Contributor Author

evgeni commented Sep 27, 2023

@joshcooper done

@joshcooper
Copy link
Contributor

GH is confused about which checks to run. Closing and reopening to retrigger with the correct list.

@joshcooper joshcooper closed this Sep 27, 2023
@joshcooper joshcooper reopened this Sep 27, 2023
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @evgeni!

@joshcooper joshcooper merged commit 65f30af into puppetlabs:7.x Sep 27, 2023
22 checks passed
@evgeni evgeni deleted the PUP-11667 branch September 28, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants