(PUP-11666) Mark resources type as valid for hosts and devices #8941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
seanmil
force-pushed
the
resources_type_apply_to_all
branch
from
5ee7523
to
1d084cf
Compare
seanmil
changed the title
|
rspec-mocks published a new gem that broke puppet tests. You'll need to rebase on 95291a9 for tests to pass. Otherwise, change looks good. |
seanmil
force-pushed
the
resources_type_apply_to_all
branch
from
1d084cf
to
d6cca0e
Compare
|
@joshcooper Thanks! Rebased. |
|
|
seanmil
force-pushed
the
resources_type_apply_to_all
branch
from
d6cca0e
to
e8aa474
Compare
|
@seanmil could you rebase on 7.x if needed? |
joshcooper
approved these changes
Oct 25, 2023
The resources type is useful on both hosts and devices and is compatible as is in both modes.
seanmil
force-pushed
the
resources_type_apply_to_all
branch
from
e8aa474
to
01c637b
Compare
@joshcooper Rebased from |
|
@seanmil I've edited your PR to target 7.x, I will close and reopen this PR to retrigger checks. Thank you! |
|
Thanks for your contribution @seanmil ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resources type is useful on both hosts and devices and is compatible as is in both modes.