Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-2040) pdk spinner inconsistent on windows #1394

Merged
merged 1 commit into from
Sep 13, 2024
Merged

(CAT-2040) pdk spinner inconsistent on windows #1394

merged 1 commit into from
Sep 13, 2024

Conversation

alex501212
Copy link
Contributor

Summary

Previously successful tasks on windows were marked with * . These changes will now tick on success, adding consistency across windows and *nix platforms.

Results from running pdk validate on a windows 10 pro vm:
Screenshot 2024-09-12 at 6 02 37 PM

Additional Context

Add any additional
context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • 🟢 Manually verified.

@alex501212 alex501212 requested a review from a team as a code owner September 13, 2024 08:30
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (4ae45a0) to head (2d57211).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1394      +/-   ##
==========================================
- Coverage   88.50%   88.49%   -0.02%     
==========================================
  Files         127      127              
  Lines        5334     5329       -5     
==========================================
- Hits         4721     4716       -5     
  Misses        613      613              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex501212 alex501212 merged commit afeb5aa into main Sep 13, 2024
9 of 11 checks passed
@alex501212 alex501212 deleted the cat_2040 branch September 13, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants