(maint) only check builtin_command? for posix
#2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `builtin_command?` only is useful in posix, where the `type` function is defined. Windows Powershell does not have `type` defined.
tvpartytonight
force-pushed
the
maint_call_builtin_command_posix_only
branch
from
39815b8
to
8075009
Compare
smortex
reviewed
Oct 21, 2022
| output.chomp =~ /builtin/ ? true : false | ||
| # optional function to be defined in subclass if necessary | ||
| def builtin_command?(_command_) | ||
| nil |
There was a problem hiding this comment.
Maybe keep false for consistency? Also the "Ruby way" for unused variable is to name them _variable.
Overall LGTM.
|
|
|
@tvpartytonight is this still needed? If so, I agree with @smortex's comments. |
|
Coming back to this, is this still needed? It looks like PowerShell can query if a command is a function like https://superuser.com/questions/1648302/powershell-equivalent-of-unix-shell-buitin-type But I'm not sure that'd be useful here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
builtin_command?only is useful in posix, where thetypefunction is defined. Windows Powershell does not have
typedefined.