From 3973aaa766611b551435601fc85d50cd82667c9a Mon Sep 17 00:00:00 2001 From: Jiwon Kim Date: Thu, 13 Jun 2024 13:05:32 +0900 Subject: [PATCH] Fix gce Starting from version 4.7.1, Facter is unable to read Gce metadata like below. [2024-06-12 04:58:49.787568 ] DEBUG Facter::Util::Resolvers::Http - Trying to connect to http://metadata.google.internal/computeMetadata/v1/?recursive=true&alt=json but got: undefined method `[]' for false:FalseClass This is because get_request is getting 4 parameters. This commit set timeouts = {}, to avoid timeouts = false. --- lib/facter/resolvers/gce.rb | 2 +- spec/facter/resolvers/gce_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/facter/resolvers/gce.rb b/lib/facter/resolvers/gce.rb index ba612ddd2a..a1b0db12d4 100644 --- a/lib/facter/resolvers/gce.rb +++ b/lib/facter/resolvers/gce.rb @@ -22,7 +22,7 @@ def read_facts(fact_name) end def query_for_metadata - gce_data = extract_to_hash(Facter::Util::Resolvers::Http.get_request(METADATA_URL, HEADERS, false)) + gce_data = extract_to_hash(Facter::Util::Resolvers::Http.get_request(METADATA_URL, HEADERS, {}, false)) parse_instance(gce_data) gce_data.empty? ? nil : gce_data diff --git a/spec/facter/resolvers/gce_spec.rb b/spec/facter/resolvers/gce_spec.rb index 8584f0d43e..a4f3124bb6 100644 --- a/spec/facter/resolvers/gce_spec.rb +++ b/spec/facter/resolvers/gce_spec.rb @@ -6,7 +6,7 @@ before do allow(Facter::Util::Resolvers::Http).to receive(:get_request) - .with(gce_metadata_url, gce_url_headers, false) + .with(gce_metadata_url, gce_url_headers, {}, false) .and_return(http_response_body) end