Re-add the serviceAccountName field to Stack.spec #720
Assignees
Labels
kind/task
Work that's part of an ongoing epic
needs-triage
Needs attention from the triage team
resolution/fixed
This issue was fixed
Comments
|
Added to epic #586 |
5 tasks
EronWright
added a commit
that referenced
this issue
Oct 18, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
Adds a top-level `serviceAccountName` to the Stack spec, since it is
practically a required element for every stack.
Note that the `workspaceTemplate` would take precedence.
The Workspace applies the default value of `default` if none is
specified.
Side-effect: some outdated manifests were regenerated.
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
Closes #720
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Virtually all stacks should have an associated service account, so the serviceAccountName should be a top-level field as opposed to being buried in the workspaceTemplate (which is intended for extensibility and advanced use cases).
The text was updated successfully, but these errors were encountered: