Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding role and rolebinding for flux source access #479

Closed
budimanjojo opened this issue Aug 22, 2023 · 5 comments · Fixed by #480
Closed

Allow adding role and rolebinding for flux source access #479

budimanjojo opened this issue Aug 22, 2023 · 5 comments · Fixed by #480
Assignees
@dirien
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@budimanjojo
Copy link
Contributor

budimanjojo commented Aug 22, 2023 •
edited
Loading

Hello!

Currently the helm chart doesn't include any way to allow the operator to access flux source. It would be good to include it.

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Affected area/feature

Tasks
Beta Give feedback
No tasks being tracked yet.
@budimanjojo budimanjojo added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Aug 22, 2023
@rquitales
Copy link
Contributor

Hello @budimanjojo,

Thank you for suggesting this enhancement.The addition of Helm chart support is a new supported installation method, so thanks for pointing out the lack of Flux source support - we'll look into adding this soon.

cc @dirien who implemented the initial Helm chart support.

@rquitales rquitales removed the needs-triage Needs attention from the triage team label Aug 22, 2023
@dirien
Copy link
Contributor

dirien commented Aug 22, 2023

Np, @budimanjojo,

let me create a PR for this!

@dirien dirien mentioned this issue Aug 22, 2023
Merged
@dirien
Copy link
Contributor

dirien commented Aug 22, 2023 •
edited
Loading

Hey @budimanjojo and @rquitales,

here is the PR #480

OCI chart version 0.2.0 should give access (get,list,watch) to the Flux Source.

@budimanjojo
Copy link
Contributor Author

Thanks!

dirien added a commit that referenced this issue Mar 6, 2024
@dirien
feat: add cluster role and fluxcd crd rules to role (#480)
e7a2bb4 
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
    for Pulumi's contribution guidelines.

    Help us merge your changes more quickly by adding more details such
    as labels, milestones, and reviewers.-->

### Proposed changes

<!--Give us a brief description of what you've done and what it solves.
-->

Hi,

this PR adds optional cluster role support plus adding the FluxCD CR to
the (non-cluster) role


### Related issues (optional)

<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->

Closes #479
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Mar 6, 2024
@dirien
Copy link
Contributor

dirien commented Mar 6, 2024

@budimanjojo 0.7.0 😅

budimanjojo added a commit to budimanjojo/home-cluster that referenced this issue Mar 7, 2024
@budimanjojo
feat(apps): no longer needed
1c2406a 
ref: pulumi/pulumi-kubernetes-operator#479

Signed-off-by: budimanjojo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dirien dirien

Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add cluster role and fluxcd crd rules to role pulumi/pulumi-kubernetes-operator
4 participants
@budimanjojo @rquitales @pulumi-bot @dirien