Fix missing signal connection in r_dp_req type #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvantor
force-pushed
the
cl/backend-tpl
branch
2 times, most recently
from
3d19dd2
to
a600031
Compare
yvantor
changed the title
|
I am marking this as reaady for review. |
|
@thommythomaso If you don't have comments, I think this is ready to be merged; Chao should have tested it by generating a Cheshire bitstream for Genesys2. @chaoqun-liang can you confirm? |
|
yes, i do have a bitstream generated for genesys2 |
|
@thommythomaso I bumped the iDMA commit into Cheshire to the deploy branch associated to this PR. Please, have a look at the CI, the FPGA implementation is succeeding. What is breaking the VCU128 boot is not related to the iDMA. I think this can be merged. |
thommythomaso
force-pushed
the
cl/backend-tpl
branch
from
a600031
to
0ac4fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It seems the missing
is_singlesignal inr_dp_reqstucture is causing problem in synthesis.Here is the related CI check results, just in case you want to have a look : )
Thank you! @thommythomaso