Add initiator mask for redundant execution. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The main branch will be subject to a major PR (#5). Do you believe we should add this feature on the current version or port it directly to the newer one? |
|
I have no strong opinion, honestly; this change is so simple that we can either wait for the PR you mentioned to be closed and then rebase and merge, or I can open the PR directly on the branch you have worked on (but this will need a rebase in any case because I branched out of master). I was approaching this by merging the change into the master to apply directly on the release just for logical order (we merge one feature at a time). We can do all at once, let me know what you prefer! |
|
The feature was added on top of the reworked version in b4fa1b5. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.